Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: Remove i18n references from save properties #43035

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

ryanwelcher
Copy link
Contributor

What?

This PR removes the save property __() reference.

Why?

As point out by @talldan in #42745 (comment), the save property cannot contain internationalization as it could cause errors in the block editor if the block was saved in one language and then loaded in another

How?

Removes the references to __()

@ryanwelcher ryanwelcher requested a review from gziolo as a code owner August 5, 2022 17:00
@ryanwelcher ryanwelcher requested a review from talldan August 5, 2022 17:01
@ryanwelcher ryanwelcher added the [Tool] Create Block /packages/create-block label Aug 5, 2022
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that. It will prevent the issues with block invalidation when the block is editing using different locales as explained in #43013.

@gziolo gziolo merged commit e2b293d into trunk Aug 8, 2022
@gziolo gziolo deleted the fix/update-create-block-template branch August 8, 2022 07:58
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label Aug 8, 2022
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Aug 8, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Sep 14, 2022
@bph bph mentioned this pull request Sep 14, 2022
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Tool] Create Block /packages/create-block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants